feat: add EOSE class to obtain subscriptionId #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethicnology
changed the title
ethicnology
changed the title
ethicnology
changed the title
ethicnology
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, maybe I should've open an issue first, but I got this implementation, so I thought it'd be fast if you check the code directory.
what I added
added class that represent EOSE mesasge.
it only has subscription field.
motivation
Currently, there is no
subscriptionIdfield in theMessageof dart-nostr, nor is there any class representating eose.in the case there are several subscriptions on one relay, we may want to distinguish which subscription is the received eose related to.
to achieve this, we need to know eose's subscription id.